Go: de-bazel checks in test action - #22372
Merged
Merged
Conversation
The codegen drift and gofmt checks move to `semmle-code`, so drop them here to avoid duplication and replace the bazel build with a plain `go build ./...` sanity check. Keep the qhelp-to-markdown steps. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
owen-mc
approved these changes
Aug 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces Bazel-based Go extractor checks with a lightweight standard Go build while delegating formatting and generated-code checks to companion CI.
Changes:
- Removes Bazel code-generation and formatting checks.
- Builds extractor packages with
go build ./.... - Retains optional qhelp generation and upload.
Show a summary per file
| File | Description |
|---|---|
go/actions/test/action.yml |
Simplifies Go extractor CI checks and removes Bazel build usage. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The generated-code drift check and the gofmt formatting check are moving to a companion CI job that can piggyback on that pipeline's bazel cache. To avoid running them in two places, we drop those two checks here and keep a lightweight, non-bazel
go buildsanity check so this repo still verifies the Go extractor compiles with the standard toolchain.Changes to
go/actions/test/action.ymlbazel run go:gen+git diff).cd go && make check-formatting).bazel run go:go-installer) with a plaincd go/extractor && go build ./....Note
This depends on the companion change landing first. Merging this before that lands would leave a short window where neither side runs the codegen + gofmt checks.